Commit graph

189 commits

Author SHA1 Message Date
Russ Cox
833216fef8 acme: add comment for aligned writes
TBR=r
https://codereview.appspot.com/89510044
2014-04-19 13:44:06 -04:00
Russ Cox
1d2c3c3945 acme: use buffered i/o to write file
Bakul Shah has observed corrupted files being written
when acme writes over osxfuse to sshfs to a remote file system.
In one example we examined, acme is writing an 0xf03-byte
file in two system calls, first an 0x806-byte write and then a 0x6fd-byte
write. (0x806 is BUFSIZE/sizeof(Rune); this file has no multibyte UTF-8.)

What actually ends up happening is that an 0x806-byte file is written:

        0x000-0x6fd contains what should be 0x806-0xf03
        0x6fd-0x7fa contains zeros
        0x7fa-0x806 contains what should be 0x7fa-0x806 (correct!)

The theory is that fuse or sshfs or perhaps the remote file server is
mishandling the unaligned writes. acme does not seem to be at fault.

Using bio here will make the writes align to 8K boundaries,
avoiding the bugs in whatever underlying piece is broken.

TBR=r
https://codereview.appspot.com/89550043
2014-04-19 10:09:22 -04:00
Russ Cox
d213189122 acme: fix Get of dir in nameless window (thanks Colton Lewis)
TBR=r
https://codereview.appspot.com/89390043
2014-04-18 14:03:46 -04:00
Ethan Burns
4030a6c905 acme: copy/cut/paste with ctl+c,x,v
LGTM=rsc
R=rsc
CC=plan9port.codebot
https://codereview.appspot.com/69070045
2014-03-13 18:48:41 -04:00
Russ Cox
219cf22d68 acme, sam: handle >1GB files correctly
TBR=rsc
https://codereview.appspot.com/74060043
2014-03-13 18:46:28 -04:00
Rob Pike
5a69e405fc acme: scroll a directory window when navigating if:
- the cursor is on the last line
        - the navigation would put the cursor over the tag of the following text

R=rsc
CC=smckean83
https://codereview.appspot.com/15280045
2013-10-22 16:47:48 -07:00
Marius Eriksen
fea86f0639 acme: execute commands with / using shell
This allows commands in bin subdirectories.

R=rsc
CC=plan9port.codebot
https://codereview.appspot.com/13254044
2013-09-06 16:23:49 -04:00
Akshat Kumar
7603066e73 acme Mail: add Search command
Introduces the Search command for mailboxes.
Arguments passed are treated as one space-
separated string, passed on to mailfs' IMAP
search interface.

R=rsc, david.ducolombier
CC=plan9port.codebot
https://codereview.appspot.com/13238044
2013-09-06 16:19:57 -04:00
Akshat Kumar
951fef52c9 mailfs: allow spaces in box name
Mail services (such as Google Mail) will often have
directories with names that contain spaces. Acme
does not support spaces in window names. So, replace
spaces in mail directory names with the Unicode
character for visible space.

The code is a bit of an over-approximation and
generally non-optimal.

R=rsc, david.ducolombier, 0intro
CC=plan9port.codebot
https://codereview.appspot.com/13010048
2013-09-06 16:10:26 -04:00
Russ Cox
2bc9a13faf acme: allow :6 in 5-line file
R=rsc
https://codereview.appspot.com/12162043
2013-07-31 09:15:30 -04:00
Russ Cox
c96d832508 acme: retina scaling for scroll bars, button
R=rsc
http://codereview.appspot.com/6854094
2012-11-26 00:33:05 -05:00
Marius Eriksen
2589c5c6ee acme: set $samfile (same as $%) during execution
R=rsc
CC=plan9port.codebot
http://codereview.appspot.com/6854092
2012-11-25 22:56:08 -05:00
Russ Cox
9ca6e21f3d acme: use threadspawnd to avoid changing "." of current process
R=rsc
http://codereview.appspot.com/6736060
2012-10-22 12:32:31 -04:00
Marius Eriksen
81c2c5e775 acme: add $acmeshell to control execution shell
R=rsc
CC=plan9port.codebot
http://codereview.appspot.com/6614056
2012-10-21 16:52:08 -04:00
Russ Cox
220c15d2b7 fix gcc 4.7 warnings (thanks Tuncer Ayaz)
R=rsc
http://codereview.appspot.com/6744053
2012-10-20 13:36:52 -04:00
Erik Quanstrom
5b6028903d acme: correct writes of runes on auspicious byte boundaries
R=rsc, r
CC=plan9port.codebot
http://codereview.appspot.com/6586067
2012-10-05 16:42:25 -04:00
Russ Cox
37f8ed2410 acme: mouse movement for Del
If the mouse was in the tag of the old window,
it was most likely pointing at Del. If bringing up a
new window from below and not moving the mouse
somewhere else, adjust it so that it ends up pointing
at Del in the replacement window's tag too.
This makes it easy to Del a sequence of windows in
a column, from top to bottom.

http://www.youtube.com/watch?v=ET8w6RT6u5M

R=r
http://codereview.appspot.com/6558047
2012-09-23 22:01:56 -04:00
David Jeannot
258cfab2fe acme: claim input focus earlier
R=rsc
CC=plan9port.codebot
http://codereview.appspot.com/5505091
2012-01-16 17:05:39 -05:00
Sean McKean
81c30b5a75 acme: fix arrow near end of text
R=rsc
CC=plan9port.codebot
http://codereview.appspot.com/5399050
2011-11-17 14:46:14 -05:00
David Jeannot
a287dbab23 devdraw: draft cocoa support
R=rsc
CC=plan9port.codebot
http://codereview.appspot.com/4974060
2011-09-06 10:10:43 -04:00
Russ Cox
da7e3a5d39 acme: fix iq1 adjust bug
R=rsc
http://codereview.appspot.com/4816066
2011-08-02 07:57:48 -04:00
Russ Cox
76864eb6cd acme: scrolling fixes + new home/end
Home and End previously navigated between
two different window locations: the top and
the bottom of the text.  Now they include a
third waypoint: the location where typing last
happened.  Thus, in a win window, typing
	ls -l
	<home>
scrolls to the beginning of the ls -l output.
A second <home> continues to the top of the file.

Makes Send scroll always, along with writes by
external programs to +Errors.

R=r
CC=mccoyst
http://codereview.appspot.com/4830051
2011-08-02 07:44:11 -04:00
Russ Cox
67afaf385a acme: allow :?regexp for backward search
Fixes issue 80.

R=rsc
http://codereview.appspot.com/4662088
2011-07-10 20:35:23 -04:00
Russ Cox
ff4512ee90 acme: fix out of order address crash
R=rsc
http://codereview.appspot.com/4690042
2011-07-10 20:32:01 -04:00
David du Colombier
363062eab4 acme Mail: drop noscroll
R=rsc
CC=plan9port.codebot
http://codereview.appspot.com/4539098
2011-06-01 18:12:12 -04:00
Russ Cox
ba31ab3044 9term, acme: autoscroll
Ignore scroll/noscroll window setting.
Instead, scroll when the write begins in
or immediately after the displayed window content.

In the new scrolling discipline, executing
"Noscroll" is replaced by typing Page Up or
using the mouse to scroll higher in the buffer,
and executing "Scroll" is replaced by typing End
or using the mouse to scroll to the bottom of
the buffer.

R=r, r2
http://codereview.appspot.com/4433060
2011-04-27 13:18:07 -04:00
Rob Pike
a208917e7a acme: fix rounding in rows computation
R=rsc
CC=codebot
http://codereview.appspot.com/2007045
2010-08-24 10:16:32 -04:00
Russ Cox
36d9b90c56 acme, sam: fix regexp code for bigger Runemax
R=r
http://codereview.appspot.com/1765042
2010-07-14 11:10:59 -07:00
Russ Cox
75a851e927 acme: fix off by one in editcmd, pointer comparison in getch, nextc
R=r
http://codereview.appspot.com/868046
2010-07-14 11:08:42 -07:00
Russ Cox
be856b940f acme: attempt to fix Put mtime skew on NFS
R=r
http://codereview.appspot.com/583043
2010-03-18 18:07:39 -07:00
Russ Cox
68a6e0c0d0 acme: let Edit redo when file is clean
R=, rsc
CC=
http://codereview.appspot.com/188042
2010-01-12 11:11:19 -08:00
Fazlul Shahriar
63479cfb79 acme: fix Load of acme with no windows
R=rsc
CC=codebot
http://codereview.appspot.com/161048
2009-11-30 12:35:05 -08:00
Russ Cox
daea2c7d50 acme: correct modified message after initial load; more detail in
message

http://codereview.appspot.com/123051
2009-09-25 01:43:54 -04:00
Mathieu Lonjaret
7b5db1c35a libplumb, Mail: fix crash on nil plumb fids
http://codereview.appspot.com/116083
2009-09-12 15:25:51 -04:00
Russ Cox
0cadb4301d convert to 4-byte UTF-8 and 32-bit Rune
http://codereview.appspot.com/116075
2009-09-11 17:03:06 -04:00
Russ Cox
4dbf255619 acme: htmlclick takes precedence over line click
http://codereview.appspot.com/116074
2009-09-11 14:54:43 -04:00
Russ Cox
e47d0a1e98 acme: angle bracket tag matching, for XML, HTML etc
http://codereview.appspot.com/98042
2009-07-26 15:05:07 -04:00
Russ Cox
cb92a1b41c acme: do not redraw body on every tag change
fixes #5
http://bitbucket.org/rsc/plan9port/issue/5/
http://groups.google.com/group/plan9port-dev/t/e679347ecaa05cff

http://codereview.appspot.com/95041
2009-07-15 02:11:02 -04:00
Russ Cox
e6c837d612 merge 2009-07-14 22:55:52 -07:00
Michael Teichgräber
4a18fa68b0 src: use whatis instead of which 2009-07-08 09:18:42 -07:00
Russ Cox
77ac358321 merge 2009-06-09 09:26:13 -07:00
Russ Cox
4aad1a3258 merge 2009-04-30 07:29:24 -07:00
Russ Cox
cb53addfae acme: fix Load bug (Fazlul Shahriar) 2008-12-06 16:24:47 -08:00
Peter Canning
611cf11c03 acme: Dump and Load tag contents 2008-07-20 03:14:55 -04:00
Russ Cox
4163694051 acme: multiline tag fixes 2008-03-07 12:51:41 -05:00
Russ Cox
a2db69c8bd acme: revise multiline tag code 2008-03-07 11:07:17 -05:00
Russ Cox
cb1ac4c41d acme: remove -$ 2008-03-07 10:46:58 -05:00
Russ Cox
5f5dd85d10 acme: remove -$ prototypes 2008-03-07 10:46:42 -05:00
Russ Cox
734a96bd16 acme: sync against Plan 9, remove -$ option 2008-03-07 10:45:59 -05:00
Russ Cox
7927fe8f9e acme: add nomenu, menu ctl messages 2008-03-07 10:41:50 -05:00