Commit graph

10 commits

Author SHA1 Message Date
Igor Burago
e4b913866b plumber: fail on buffer exhaustion or runaway quotes in string expansion 2022-09-06 13:21:23 -04:00
Fazlul Shahriar
b9424f640a plumber: fix EOF detection on writes to rules file (#257)
Instead of checking Fcall.data==nil, check Fcall.count==0.
The former check always fails after `gcc -O2` optimizations
(gcc version 8.3.0).

Also fix an out-of-bound read detected by valgrind:
```
==31162== Invalid read of size 1
==31162==    at 0x11005E: morerules (rules.c:739)
==31162==    by 0x110254: writerules (rules.c:775)
==31162==    by 0x10D2FE: fsyswrite (fsys.c:848)
==31162==    by 0x10C304: fsysproc (fsys.c:248)
==31162==    by 0x112E8C: threadstart (thread.c:96)
==31162==    by 0x4A682BF: ??? (in /usr/lib/libc-2.29.so)
==31162==  Address 0x4ea984a is 0 bytes after a block of size 250 alloc'd
==31162==    at 0x483AD7B: realloc (vg_replace_malloc.c:826)
==31162==    by 0x1196F3: p9realloc (malloc.c:53)
==31162==    by 0x10BDFD: erealloc (plumber.c:124)
==31162==    by 0x10FCD9: concat (rules.c:642)
==31162==    by 0x10FCD9: concat (rules.c:635)
==31162==    by 0x110230: writerules (rules.c:773)
==31162==    by 0x10D2FE: fsyswrite (fsys.c:848)
==31162==    by 0x10C304: fsysproc (fsys.c:248)
==31162==    by 0x112E8C: threadstart (thread.c:96)
==31162==    by 0x4A682BF: ??? (in /usr/lib/libc-2.29.so)
```

Fixes #256
2019-09-19 13:08:54 -04:00
Russ Cox
c149b06f2e plumb: remove debugging print
R=rsc
http://codereview.appspot.com/6210059
2012-05-15 10:55:53 -04:00
rsc
3bd56b04a8 NetBSD-macppc ctype needs uchars. 2005-09-09 23:16:15 +00:00
rsc
4de03b544c add $plan9 variable 2005-01-11 19:46:06 +00:00
rsc
8ad517944e Today's changes.
More changes.
2004-03-25 23:03:57 +00:00
rsc
15680d56a6 Amazingly picky bug fixes from Valgrind. 2004-03-05 05:53:11 +00:00
rsc
c91bd3283a Pipes cannot use SOCK_DGRAM. Back to SOCK_STREAM.
Add debugging to fdwait.

Rewrite getcallerpc on PowerMac to be correct.
2004-03-05 02:25:41 +00:00
rsc
32f69c36e0 Add support for user-level 9P servers/clients and various bug fixes to go with them. 2003-12-11 17:48:38 +00:00
rsc
b8c14089d8 Plan 9 version, nothing tweaked yet. 2003-11-23 17:58:26 +00:00