o5r/plan9port
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

lib9, libndb: exclude terminating null from strncpy bound

Browse source 
GCC pointed this out with some "warning: ‘strncpy’ specified bound NUM
equals destination size [-Wstringop-truncation]" warnings.

Change-Id: Id8408b165f6e4ae82c96a77599d89f658d979b32
This commit is contained in:
Neven Sajko 2020-01-06 22:57:05 +00:00 • committed by Dan Cross
parent 540caa5873
commit e6ed10f25e
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/lib9/ctime.c
View file

@ -58,7 +58,7 @@ localtime(long tim)
if (zonelookuptinfo(&ti, tim)!=-1) { if (zonelookuptinfo(&ti, tim)!=-1) {
ct = gmtime(tim+ti.tzoff); ct = gmtime(tim+ti.tzoff);
strncpy(ct->zone, ti.zone, sizeof ct->zone); strncpy(ct->zone, ti.zone, sizeof ct->zone - 1);
ct->zone[sizeof ct->zone-1] = 0; ct->zone[sizeof ct->zone-1] = 0;
ct->tzoff = ti.tzoff; ct->tzoff = ti.tzoff;
return ct; return ct;

2
src/libndb/sysdnsquery.c
View file

@ -84,7 +84,7 @@ mkptrname(char *ip, char *rip, int rlen)
static void static void
nstrcpy(char *to, char *from, int len) nstrcpy(char *to, char *from, int len)
{ {
strncpy(to, from, len); strncpy(to, from, len-1);
to[len-1] = 0; to[len-1] = 0;
} }