libdraw: fix some memory leaks in font handling

This commit is contained in:
Xiao-Yong Jin 2018-03-20 22:17:57 -05:00 committed by David du Colombier
parent a3ec102dc7
commit dc2a17b95c
5 changed files with 18 additions and 6 deletions

View file

@ -36,6 +36,7 @@ buildfont(Display *d, char *buf, char *name)
if(fnt->name==0 || fnt->cache==0 || fnt->subf==0){
Err2:
free(fnt->name);
free(fnt->namespec);
free(fnt->cache);
free(fnt->subf);
free(fnt->sub);

View file

@ -12,6 +12,7 @@ freesubfont(Subfont *f)
return;
uninstallsubfont(f);
free(f->info); /* note: f->info must have been malloc'ed! */
free(f->name);
freeimage(f->bits);
free(f);
}

View file

@ -31,7 +31,7 @@ openfont1(Display *d, char *name)
{
Font *fnt;
int fd, i, n, scale;
char *buf, *nambuf, *fname, *freename;
char *buf, *nambuf, *nambuf0, *fname, *freename;
nambuf = 0;
freename = nil;
@ -42,19 +42,21 @@ openfont1(Display *d, char *name)
nambuf = smprint("#9/font/%s", fname+14);
if(nambuf == nil)
return 0;
nambuf = unsharp(nambuf);
*nambuf0 = unsharp(nambuf);
if(nambuf0 != nambuf)
free(nambuf);
nambuf = nambuf0;
if(nambuf == nil)
return 0;
if((fd = open(nambuf, OREAD)) < 0){
free(nambuf);
return 0;
}
fname = nambuf;
if(scale > 1) {
name = smprint("%d*%s", scale, fname);
name = smprint("%d*%s", scale, nambuf);
freename = name;
} else {
name = fname;
name = nambuf;
}
}
if(fd >= 0)
@ -63,13 +65,17 @@ openfont1(Display *d, char *name)
fd = _fontpipe(fname+10);
n = 128*1024;
}
if(fd < 0)
if(fd < 0){
free(nambuf);
free(freename);
return 0;
}
buf = malloc(n+1);
if(buf == 0){
close(fd);
free(nambuf);
free(freename);
return 0;
}
i = readn(fd, buf, n);
@ -77,6 +83,7 @@ openfont1(Display *d, char *name)
if(i <= 0){
free(buf);
free(nambuf);
free(freename);
return 0;
}
buf[i] = 0;
@ -224,6 +231,7 @@ openfont(Display *d, char *name)
if(!f)
return nil;
f->lodpi = f;
free(f->namespec);
f->namespec = namespec;
/* add to display list for when dpi changes */

View file

@ -34,6 +34,7 @@ void
uninstallsubfont(Subfont *subfont)
{
if(subfont == lastsubfont){
free(lastname);
lastname = 0;
lastsubfont = 0;
}

View file

@ -47,6 +47,7 @@ subfontname(char *cfname, char *fname, int maxdepth)
}
return tmp2;
}
free(tmp2);
}
/* try default */