Avoid storing precious data below the stack pointer.

src/libmp/386/mpdigdiv.s

@@ -1,19 +1,19 @@
 .text
-
 .p2align 2,0x90
 .globl mpdigdiv
 	.type mpdigdiv, @function
 mpdigdiv:
 	/* Prelude */
-	pushl %ebp
+	pushl %ebp		/* save on stack */
-	movl %ebx, -4(%esp)		/* save on stack */
+	pushl %ebx
 	
-	movl	8(%esp), %ebx
+	leal 12(%esp), %ebp	/* %ebp = FP for now */
-	movl	(%ebx), %eax
+	movl 0(%ebp), %ebx	/* dividend */
-	movl	4(%ebx), %edx
+	movl 0(%ebx), %eax
+	movl 4(%ebx), %edx
+	movl 4(%ebp), %ebx	/* divisor */
+	movl 8(%ebp), %ebp	/* quotient */
 
-	movl	12(%esp), %ebx
-	movl	16(%esp), %ebp
 	xorl	%ecx, %ecx
 	cmpl	%ebx, %edx		/* dividend >= 2^32 * divisor */
 	jae	divovfl
@@ -21,19 +21,14 @@ mpdigdiv:
 	je	divovfl
 	divl	%ebx		/* AX = DX:AX/BX */
 	movl	%eax, (%ebp)
-	jmp done
+done:
+	/* Postlude */
+	popl %ebx
+	popl %ebp
+	ret
 
 	/* return all 1's */
 divovfl:
 	notl	%ecx
 	movl	%ecx, (%ebp)
-
+	jmp done
-done:
-	/* Postlude */
-	movl -4(%esp), %ebx		/* restore from stack */
-	movl %esp, %ebp
-	leave
-	ret
-
-.endmpdigdiv:
-	.size mpdigdiv,.endmpdigdiv-mpdigdiv

src/libmp/386/mpvecadd.s

@@ -10,17 +10,19 @@
 	.type mpvecadd, @function
 mpvecadd:
 	/* Prelude */
-	pushl %ebp
+	pushl %ebp		/* save on stack */
-	movl %ebx, -4(%esp)		/* save on stack */
+	pushl %ebx
-	movl %esi, -8(%esp)
+	pushl %esi
-	movl %edi, -12(%esp)
+	pushl %edi
 
-	movl	12(%esp), %edx		/* alen */
+	leal 20(%esp), %ebp		/* %ebp = FP for now */
-	movl	20(%esp), %ecx		/* blen */
+
-	movl	8(%esp), %esi		/* a */
+	movl	4(%ebp), %edx		/* alen */
-	movl	16(%esp), %ebx		/* b */
+	movl	12(%ebp), %ecx		/* blen */
+	movl	0(%ebp), %esi		/* a */
+	movl	8(%ebp), %ebx		/* b */
 	subl	%ecx, %edx
-	movl	24(%esp), %edi		/* sum */
+	movl	16(%ebp), %edi		/* sum */
 	xorl	%ebp, %ebp		/* this also sets carry to 0 */
 
 	/* skip addition if b is zero */
@@ -62,9 +64,8 @@ _addloop2:
 
 done:
 	/* Postlude */
-	movl -4(%esp), %ebx		/* restore from stack */
+	popl %edi
-	movl -8(%esp), %esi
+	popl %esi
-	movl -12(%esp), %edi
+	popl %ebx
-	movl %esp, %ebp
+	popl %ebp
-	leave
 	ret

src/libmp/386/mpvecdigmuladd.s

@@ -27,15 +27,16 @@
 	.type mpvecdigmuladd, @function
 mpvecdigmuladd:
 	/* Prelude */
-	pushl %ebp
+	pushl %ebp		/* save on stack */
-	movl %ebx, -4(%esp)		/* save on stack */
+	pushl %ebx
-	movl %esi, -8(%esp)
+	pushl %esi
-	movl %edi, -12(%esp)
+	pushl %edi
 
-	movl	8(%esp), %esi		/* b */
+	leal 20(%esp), %ebp		/* %ebp = FP for now */
-	movl	12(%esp), %ecx		/* n */
+	movl	0(%ebp), %esi		/* b */
-	movl	16(%esp), %ebx		/* m */
+	movl	4(%ebp), %ecx		/* n */
-	movl	20(%esp), %edi		/* p */
+	movl	8(%ebp), %ebx		/* m */
+	movl	12(%ebp), %edi		/* p */
 	movl	%ecx, %ebp
 	negl	%ebp			/* BP = -n */
 	shll	$2, %ecx
@@ -61,9 +62,9 @@ _muladdnocarry2:
 	adcl	%eax, %eax		/* return carry out of p[n] */
 
 	/* Postlude */
-	movl -4(%esp), %ebx		/* restore from stack */
+	popl %edi
-	movl -8(%esp), %esi
+	popl %esi
-	movl -12(%esp), %edi
+	popl %ebx
-	movl %esp, %ebp
+	popl %ebp
-	leave
 	ret
+

src/libmp/386/mpvecsub.s

@@ -10,16 +10,18 @@
 	.type mpvecsub, @function
 mpvecsub:
 	/* Prelude */
-	pushl %ebp
+	pushl %ebp		/* save on stack */
-	movl %ebx, -4(%esp)		/* save on stack */
+	pushl %ebx
-	movl %esi, -8(%esp)
+	pushl %esi
-	movl %edi, -12(%esp)
+	pushl %edi
+
+	leal 20(%esp), %ebp		/* %ebp = FP for now */
+	movl	0(%ebp), %esi		/* a */
+	movl	8(%ebp), %ebx		/* b */
+	movl	4(%ebp), %edx		/* alen */
+	movl	12(%ebp), %ecx		/* blen */
+	movl	16(%ebp), %edi		/* diff */
 
-	movl	8(%esp), %esi		/* a */
-	movl	16(%esp), %ebx		/* b */
-	movl	12(%esp), %edx		/* alen */
-	movl	20(%esp), %ecx		/* blen */
-	movl	24(%esp), %edi		/* diff */
 	subl	%ecx,%edx
 	xorl	%ebp,%ebp			/* this also sets carry to 0 */
 
@@ -46,15 +48,14 @@ _subloop2:
 	movl	(%esi, %ebp, 4), %eax
 	sbbl	$0, %eax
 	movl	%eax, (%edi, %ebp, 4)
-	INCL	%ebp
+	incl	%ebp
-	LOOP	_subloop2
+	loop	_subloop2
 
 done:
 	/* Postlude */
-	movl -4(%esp), %ebx		/* restore from stack */
+	popl %edi
-	movl -8(%esp), %esi
+	popl %esi
-	movl -12(%esp), %edi
+	popl %ebx
-	movl %esp, %ebp
+	popl %ebp
-	leave
 	ret