o5r/plan9port
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

devdraw: fix cocoa metal _flushmemscreen for invalid rectangles (#240)

Browse source 
It is possible to receive multiple screen resize events, and resizeimg
would be called for different sizes, before _flushmemscreen actually
gets called with rectangle sizes different from the most recent
resizeimg call.  The size mismatch would trigger illegal memory
access inside _flushmemscreen.

This commit protects _flushmemscreen by returning early if the requested
rectangle is outside of the current texture rectangle.
This commit is contained in:
Xiao-Yong 2019-04-05 12:44:47 -06:00 • committed by Russ Cox
parent 4d3c36cce4
commit 0308e1f010
1 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/cmd/devdraw/cocoa-screen-metal.m
View file

@ -987,6 +987,10 @@ void
_flushmemscreen(Rectangle r) _flushmemscreen(Rectangle r)
{ {
LOG(@"_flushmemscreen(%d,%d,%d,%d)", r.min.x, r.min.y, Dx(r), Dy(r)); LOG(@"_flushmemscreen(%d,%d,%d,%d)", r.min.x, r.min.y, Dx(r), Dy(r));
if(!rectinrect(r, Rect(0, 0, texture.width, texture.height))){
LOG(@"Rectangle is out of bounds, return.");
return;
}
@autoreleasepool{ @autoreleasepool{
[texture [texture