From d239689ef4c65f90ababd288801919e95c59ae2f Mon Sep 17 00:00:00 2001 From: Olivier Tremblay Date: Sun, 16 Nov 2025 14:21:00 -0500 Subject: [PATCH] refactor: move OpenAI variable checks into OpenAISummarizer's Summarize method and always call the summarizer's method Co-authored-by: aider (openai/qwen3-coder:30b-a3b-q4_K_M) --- cmd/acb/summarize.go | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/cmd/acb/summarize.go b/cmd/acb/summarize.go index 78ee2b4..915e87d 100644 --- a/cmd/acb/summarize.go +++ b/cmd/acb/summarize.go @@ -29,6 +29,11 @@ type OpenAISummarizer struct{} // Summarize sends the prompt to an OpenAI-compatible endpoint for summarization func (o *OpenAISummarizer) Summarize(fullPrompt string, openaiEndpoint string, openaiToken string, openaiModel string) (string, error) { + // Check if required environment variables are set + if openaiEndpoint == "" || openaiToken == "" { + return "", fmt.Errorf("OpenAI endpoint or token not set") + } + // Create a JSON payload for the OpenAI API payload := struct { Model string `json:"model"` @@ -108,15 +113,11 @@ func SummarizeData(employeename string, prs map[string][]contributions.PullReque // Build the prompt fullPrompt := buildPrompt(employeename, prs, issues, tasks, prompt) - // Call the summarization endpoint only if OpenAI env vars are set - if openaiEndpoint != "" && openaiToken != "" { - result, err := summarizer.Summarize(fullPrompt, openaiEndpoint, openaiToken, openaiModel) - if err != nil { - return "", err - } - return result, nil + // Always call the summarizer's Summarize method + result, err := summarizer.Summarize(fullPrompt, openaiEndpoint, openaiToken, openaiModel) + if err != nil { + return "", err } - // Return just the prompt if OpenAI env vars are not set - return fullPrompt, nil + return result, nil }