From ab9228947aa17189fa54a926084e0b366a6f324e Mon Sep 17 00:00:00 2001 From: Olivier Tremblay Date: Thu, 30 Oct 2025 18:10:01 -0400 Subject: [PATCH] refactor: Move Jira user from positional arg to flag parameter Co-authored-by: aider (openai/qwen3-coder:30b-a3b-q4_K_M) --- cmd/acb/main.go | 24 +++++++++++++++++++----- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/cmd/acb/main.go b/cmd/acb/main.go index 4bf1d06..ed8560f 100644 --- a/cmd/acb/main.go +++ b/cmd/acb/main.go @@ -17,8 +17,23 @@ func main() { start := os.Args[3] end := os.Args[4] employeename := os.Args[5] + + // Parse Jira user from flags + jiraUser := "" + for i, arg := range os.Args { + if arg == "-jira-user" && i+1 < len(os.Args) { + jiraUser = os.Args[i+1] + break + } + } + + if jiraUser == "" { + fmt.Println("Error: -jira-user flag is required") + os.Exit(1) + } + prs := DoPrs(proj, ghusername, start, end) - issues := DoJira(start, end) + issues := DoJira(start, end, jiraUser) vikunjaTasks := DoVikunja(start, end) summ, err := SummarizeData(employeename, prs, issues, vikunjaTasks) if err != nil { @@ -50,16 +65,15 @@ func DoPrs(proj, ghusername, start, end string) map[string][]contributions.PullR } return prs } -func DoJira(start, end string) []issues.Issue { +func DoJira(start, end, jiraUser string) []issues.Issue { host := os.Getenv("JIRA_HOST") - user := os.Getenv("JIRA_TARGET_USER") - issues, err := issues.GetIssues(host, user, start, end) + issues, err := issues.GetIssues(host, jiraUser, start, end) if err != nil { fmt.Println(fmt.Errorf("error getting PRs: %w", err)) os.Exit(1) } - jf, err := os.Create(fmt.Sprintf("jira-%s-%s-%s-%s-%d.json", host, user, start, end, time.Now().Unix())) + jf, err := os.Create(fmt.Sprintf("jira-%s-%s-%s-%s-%d.json", host, jiraUser, start, end, time.Now().Unix())) if err != nil { fmt.Println(fmt.Errorf("error creating JIRA file: %w", err)) os.Exit(1)