From 979aa66b17c1ae86aecc9934c77c00ec0eba56f8 Mon Sep 17 00:00:00 2001 From: Olivier Tremblay Date: Fri, 14 Nov 2025 11:22:21 -0500 Subject: [PATCH] fix: always call SummarizeData to ensure prompt file is created for debugging, but only call OpenAI endpoint if env vars are set Co-authored-by: aider (openai/qwen3-coder:30b-a3b-q4_K_M) --- cmd/acb/main.go | 15 ++++++++------- cmd/acb/summarize.go | 14 +++++++++----- 2 files changed, 17 insertions(+), 12 deletions(-) diff --git a/cmd/acb/main.go b/cmd/acb/main.go index db5a0d7..ae397b3 100644 --- a/cmd/acb/main.go +++ b/cmd/acb/main.go @@ -72,18 +72,19 @@ func main() { openaiToken := os.Getenv("OPENAI_TOKEN") openaiModel := os.Getenv("OPENAI_MODEL") - // Check if OpenAI environment variables are set before calling Summarize - if openaiEndpoint == "" || openaiToken == "" { - fmt.Println("Error: OPENAI_ENDPOINT and OPENAI_TOKEN must be set in environment variables to summarize") - os.Exit(1) - } - + // Always call SummarizeData to ensure prompt file is created for debugging summ, err := SummarizeData(*employeename, prs, issues, vikunjaTasks, finalPrompt, openaiEndpoint, openaiToken, openaiModel) if err != nil { fmt.Println(fmt.Errorf("error getting PRs: %w", err)) os.Exit(1) } - fmt.Println(summ) + + // Only call summarization endpoint if OpenAI env vars are set + if openaiEndpoint != "" && openaiToken != "" { + fmt.Println(summ) + } else { + fmt.Println("OpenAI endpoint and token not set, but prompt file was created for debugging") + } } func DoPrs(proj, ghusername, start, end string) map[string][]contributions.PullRequest { diff --git a/cmd/acb/summarize.go b/cmd/acb/summarize.go index 7177df3..c5cf9aa 100644 --- a/cmd/acb/summarize.go +++ b/cmd/acb/summarize.go @@ -100,11 +100,15 @@ func SummarizeData(employeename string, prs map[string][]contributions.PullReque // Build the prompt fullPrompt := buildPrompt(employeename, prs, issues, tasks, prompt) - // Call the summarization endpoint - result, err := callSummarizationEndpoint(fullPrompt, openaiEndpoint, openaiToken, openaiModel) - if err != nil { - return "", err + // Call the summarization endpoint only if OpenAI env vars are set + if openaiEndpoint != "" && openaiToken != "" { + result, err := callSummarizationEndpoint(fullPrompt, openaiEndpoint, openaiToken, openaiModel) + if err != nil { + return "", err + } + return result, nil } - return result, nil + // Return just the prompt if OpenAI env vars are not set + return fullPrompt, nil }